feat: use process groups for swarms #553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle swarm processes as a child process group to ensure the exit happens consistently using group kill command
Janaka-Steph
requested changes
Nov 16, 2023
There was a problem hiding this comment.
Is this PR trying to solve an existing issue or is it an optimization? For me the processes are already stopping properly on main branch.
Also the app crashes when starting the swarm.
🐍 Creating the environment...
src/controller_binaries.rs:253 2023-11-16T09:44:22 [INFO] - Stopping all services
thread panicked while processing panic. aborting.
|
It was meant for #511 will take a look, maybe I left a bug that caused a crash. Will take a look |
|
Ha ok, I thought it was the swarm from Settings. The crash happens when clicking Start from Settings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle swarm processes as a child process group to ensure the exit happens consistently using group kill command