stubbed out beehave_tree_node #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RcubDev
commented
Feb 6, 2024
| BeehaveTreeNode::TickStatus BeehaveTreeNode::tick(Ref<BeehaveContext> context) { | ||
| return BeehaveTreeNode::FAILURE; | ||
| return BeehaveTreeNode::SUCCESS; |
There was a problem hiding this comment.
Changed this to success as this is what the 2.X version was doing when I looked. I can swap it back if we want
RcubDev
commented
Feb 6, 2024
bitbrain
reviewed
Feb 8, 2024
| ClassDB::bind_method(D_METHOD("before_run"), &BeehaveTreeNode::before_run); | ||
| ClassDB::bind_method(D_METHOD("after_run"), &BeehaveTreeNode::after_run); | ||
| ClassDB::bind_method(D_METHOD("get_class_name"), &BeehaveTreeNode::get_class_name); | ||
| ClassDB::bind_method(D_METHOD("can_send_message"), &BeehaveTreeNode::can_send_message); |
There was a problem hiding this comment.
ClassDB::bind_method(D_METHOD("get_class_name"), &BeehaveTreeNode::get_class_name);
ClassDB::bind_method(D_METHOD("can_send_message"), &BeehaveTreeNode::can_send_message);
Those were needed for the debugger. Let us (for now) not define those methods and deal with that later, as with C++ we can do some fancy tricks to not rely on GDScript hacks.
bitbrain
reviewed
Feb 8, 2024
| ClassDB::bind_method(D_METHOD("tick"), &BeehaveTreeNode::tick); | ||
| ClassDB::bind_method(D_METHOD("interrupt"), &BeehaveTreeNode::interrupt); | ||
| ClassDB::bind_method(D_METHOD("before_run"), &BeehaveTreeNode::before_run); |
There was a problem hiding this comment.
I was thinking about making before_run and after_run signals in V3
|
Closing this, as this has been done already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stubbed out methods from beehave 2.X's behave node (in beehave 3.X it is renamed to beehave_tree_node). Implemented the methods I could without the blackboard being completely implemented.
Screenshots
configuration warnings working with this update:
docs updated with new methods:
