[bitnami/mongodb]Add "or" condition between .Values.auth.existingSecret and .Values.auth.rootPassword #25944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Values.auth.rootPassword Description: Ensure that the Helm chart handles authentication correctly by using an "or" condition between .Values.auth.existingSecret and .Values.auth.rootPassword while maintaining the "and" condition with .Values.auth.enabled. This allows for the use of existing secrets from Vault alongside the root password. Resolved: bitnami#25885 Signed-off-by: Soufiane Benali <soufiane.benali@aerztekasse.ch>
carrodher
added
verify
alemorcuq
previously approved these changes
May 20, 2024
Signed-off-by: Alejandro Moreno <amorenoc@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
alemorcuq
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Ensure that the Helm chart handles authentication correctly by using an "or" condition between
.Values.auth.existingSecretand.Values.auth.rootPasswordwhile maintaining the "and" condition with.Values.auth.enabled. This allows for the use of existing secrets from Vault alongside the root password.Benefits
We can specify the root password on the value or inject it via existingSecret.
Possible drawbacks
No limitations as far as I can tell.
Applicable issues
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm