-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve type safety of DOM elements on core/dom
#13735
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.5 #13735 +/- ##
==============================================
+ Coverage 91.57% 92.59% +1.01%
==============================================
Files 326 325 -1
Lines 20737 20729 -8
==============================================
+ Hits 18990 19194 +204
+ Misses 1747 1535 -212 |
core/dom
.core/dom
721670e
to
db4ee2c
Compare
I tried to use some advanced types to extract relevant attributes from TS' |
db4ee2c
to
00dda62
Compare
Previously constructs like
div({style: {margin: "10px"}, tabIndex: 0}, ...)
were pretty much dynamically typed. This PR fixes that problem and fixes any discovered issues.