Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): cleanup and add integration templates #13098

Merged
merged 5 commits into from
May 15, 2024
Merged

feat(cli): cleanup and add integration templates #13098

merged 5 commits into from
May 15, 2024

Conversation

franklevasseur
Copy link
Member

@franklevasseur franklevasseur commented May 14, 2024 •
edited

there is now 3 integration templates:

  1. empty-integration (like the name says, it's empty)
  2. hello-world (a single action that returns a hello world message with your name in it)
  3. webhook-message (integration that receive incoming messages through HTTP and respond on a webhook)

fixes CLS-2039

@linear Linear
Copy link

linear bot commented May 14, 2024

CLS-2039 cleanup and add integration templates

@franklevasseur franklevasseur marked this pull request as ready for review May 14, 2024 23:02
@franklevasseur franklevasseur requested a review from a team as a code owner May 14, 2024 23:02
@franklevasseur franklevasseur requested review from EFF and charlescatta and removed request for EFF May 14, 2024 23:02
@charlescatta
Copy link
Contributor

I would add a Hub.md template to each template integration

charlescatta
charlescatta approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@charlescatta charlescatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/cli/templates/echo-bot/package.json
"private": true,
"author": "",
"license": "MIT",
"dependencies": {
"@botpress/client": "0.16.2",
"@botpress/sdk": "0.8.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite an old version of typescript, anyway we can bump it ?

@franklevasseur franklevasseur merged commit dea07d0 into master May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlescatta charlescatta charlescatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@franklevasseur @charlescatta