Separate cairo-xlib.h Lua bindings from cairo.h #1844
Merged
+195
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows cairo.h to be used from Lua on Wayland without X11 as requirement. A way of creating surfaces in Lua that uses Shm allocated buffers should be added in future. This commit only cleans up build options to avoid weird errors. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Caellian
added
build system
✅ Deploy Preview for conkyweb canceled.
|
github-actions
bot
added
dependencies
Caellian
force-pushed
the
fix/separate-cairo-xlib
branch
from
9b236a2
to
dd32803
Compare
Caellian
commented
Apr 19, 2024
| @@ -88,7 +88,6 @@ jobs: | |||
| libaudclient-dev \ | |||
| libcairo2-dev \ | |||
| libcurl4-gnutls-dev \ | |||
| libcurl4-gnutls-dev \ | |||
Caellian
force-pushed
the
fix/separate-cairo-xlib
branch
from
dd32803
to
e279109
Compare
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
...to fix CI. Also, it just makes sense. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Obliterated the IF guard because it made me angry. Also, not needed because it doesn't **directly contain any module checks** and flags can be checked individually because dependent_option already turns them off if their dependencies aren't satisfied. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
brndnmtthws
approved these changes
Apr 19, 2024
|
if this PR has been included in v1.20.2 included in debian trixie, I still have the issue using that version
using the conky rings lua script |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows cairo.h to be used from Lua on Wayland without X11 as requirement.
A way of creating surfaces in Lua that uses Shm allocated buffers should be added in future. This PR only cleans up build options to avoid weird errors.
Closes #1804 -
BUILD_LUA_CAIROdidn't depend on X11 andlua/CMakeLists.txtdoesn't provide warnings likedependent_options do, so it wasn't clear why the build was failing withBUILD_LUA_CAIRO && !BUILD_X11.