Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use netlink instead of Wireless Extensions #1879

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Use netlink instead of Wireless Extensions #1879

wants to merge 15 commits into from

Conversation

Caellian
Copy link
Collaborator

@Caellian Caellian commented May 1, 2024 •
edited

This PR removes deprecated iwlib related code and replaces it with netlink library.

State

  • change/setup dependencies
    • update CI & Docker files
  • implement some basic code that can handle some of the existing stats
    • dispatch new requests when requests aren't in_flight already
  • simplify changes for future contributors
    • improve documentation
  • reduce diff

Testing

  • nl cache works
  • test commands
    • wireless_ap
    • wireless_bitrate
    • wireless_channel
    • wireless_essid
    • wireless_freq
    • wireless_link_qual
    • wireless_link_qual_max
    • wireless_mode
  • test default command values
  • ensure correct interface data is returned
  • ensure correct network info is returned
  • check delay between command issuing and finish callback to determine ideal handling (eager vs. lazy)
  • test what happens when conky only renders once

@Caellian
Start implementing netlink
c08970a 
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian Caellian linked an issue May 1, 2024 that may be closed by this pull request
Migrate from libiw to libnl for wireless support #1001
Open
@github-actions github-actions bot added sources PR modifies project sources dependencies Issue or PR that affects dependencies networking Issue or PR related to networking support labels May 1, 2024
@netlify Netlify
Copy link

netlify bot commented May 1, 2024 •
edited

✅ Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit 118e0f8
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/6636d912614e4d000818ad68

@brndnmtthws brndnmtthws added the feature New feature PR or issue label May 1, 2024
@Caellian
Add nl80211 header
bffecae 
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@github-actions github-actions bot added 3rdparty Issue or PR that suggests changes to 3rd party dependencies gh-actions Issue or PR that suggest changing GitHub actions build system Issues and PRs related to build system (CMake) and process labels May 1, 2024
@Caellian Caellian force-pushed the dev/netlink branch 10 times, most recently from a18dc06 to cd43e19 Compare May 1, 2024 16:00
@Caellian
Add CI dependencies and fix build issues
1ae4580 
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian
Copy iw info implementation
f6d1bfe 
Update linux headers

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian
Add genl dependency to CI
1e09e69 
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian
Move new code to netlink-conky
aa3e9b7 
Replace define with a wrapper struct.

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian
Improve API
23c9bb9 
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian
Start implementing tasks
ebc3bdf 
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Caellian
Caellian commented May 2, 2024
View reviewed changes
src/netlink-conky.h Outdated Show resolved Hide resolved
@Caellian
Add required nl80211 callbacks
830dea1 
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@github-actions github-actions bot added the macos Issue or PR related to MacOS label May 2, 2024
@Caellian
Add argument forwarding to nl_task
f109f59 
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian
Add dependencies to Dockerfile
494942a 
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian
Cleanup nested_attributes helper
f47a502 
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian
Fix runtime errors
a9b8ba7 
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian
Get interface information to work
118e0f8 
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian
Copy link
Collaborator Author

Caellian commented May 5, 2024 •
edited

Ok, got interface information to update, so this PR is ~70% done with regards to figuring stuff out:

image

@Caellian Caellian mentioned this pull request May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3rdparty Issue or PR that suggests changes to 3rd party dependencies build system Issues and PRs related to build system (CMake) and process dependencies Issue or PR that affects dependencies feature New feature PR or issue gh-actions Issue or PR that suggest changing GitHub actions macos Issue or PR related to MacOS networking Issue or PR related to networking support sources PR modifies project sources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from libiw to libnl for wireless support
2 participants
@Caellian @brndnmtthws