-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Payments Report: Add POS data columns #5630
base: master
Are you sure you want to change the base?
Conversation
199bc22
to
1d42da6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand the scope of the PR, functional tACK!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how I feel about this, it's so specific to the POS that it would be a shame to pollute such a wide-scoped report. I would see if if is possible to create a dedicated report that extends this one.
That's valid. Makes future plug-in (tip splitting, podcast splits, whatever other stuff people come up, etc...) more easily extensible, but can also see the case for simply including the core POS data breakdown here as well. |
672393e
to
9d9955d
Compare
9d9955d
to
4a4f497
Compare
Extends the payments report data with subtotal, tip and discount amounts. This works for keypad and cart sales. Closes btcpayserver#5290.
4a4f497
to
91628ad
Compare
So you're suggesting we have a dedicated app report or a pos report where we could display data for the POS app in particular? I agree with you on that one if so, thinking about |
I believe that we should allow the ability to add or remove columns in the report page. That way, we can add lot's of missing column which may be app specific, but this isn't a problem. If we agree that we can customize which columns to hide or show, we should merge that first as it is ready, and maybe book the column selection for next major. |
@NicolasDorier Could we display all data including refunds & tips with that approach? I think that's quite sensible idea for this problem, and would allow people to customize things, we're getting a lot of complaints in general that people aren't getting info they used to from the reporting, I am still working on their specific feedback. |
cACK to showing/hiding columns as per @NicolasDorier's suggestions, seems like an elegant approach to customizing the view for each use case cc @dennisreimann are we in a position to do this with tables? imagine it'll just be an additional bootstrap column with some kind of |
Extends the payments report data with subtotal, tip and discount amounts. This works for keypad and cart sales. Closes #5290.