Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAL-3425] desination calendar of old bookings changes when default calendar of event is updated #13902

Open
CarinaWolli opened this issue Feb 27, 2024 · 3 comments · May be fixed by #14994
Open

[CAL-3425] desination calendar of old bookings changes when default calendar of event is updated #13902

CarinaWolli opened this issue Feb 27, 2024 · 3 comments · May be fixed by #14994
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync linear Sync Github Issue from community members to Linear.app Medium priority Created by Linear-GitHub Sync
Milestone
v4.2

Comments

@CarinaWolli
Copy link
Member

CarinaWolli commented Feb 27, 2024 •
edited by keithwillcode

When the default calendar of an event is changed the destination calendar of all previous bookings changes as well. So when canceling the event, the calendar event is not deleted

Discussed here: #13827

each booking have a destination calendar that should be not change on changing event's default calendar.
Loom

CAL-3425
@maige-app maige-app bot added 🐛 bug Something isn't working bookings area: bookings, availability, timezones, double booking labels Feb 27, 2024
@CarinaWolli CarinaWolli mentioned this issue Feb 27, 2024
Closed
@Pritam-sd-dev
Copy link
Contributor

hi, i have started working on it.

@keithwillcode keithwillcode added the linear Sync Github Issue from community members to Linear.app label Feb 29, 2024
@keithwillcode keithwillcode added this to the v4.0 milestone Feb 29, 2024
@keithwillcode keithwillcode added Medium priority Created by Linear-GitHub Sync community Created by Linear-GitHub Sync labels Feb 29, 2024
@keithwillcode keithwillcode modified the milestones: v4.0, v4.1 Apr 15, 2024
@keithwillcode keithwillcode changed the title desination calendar of old bookings changes when default calendar of event is updated [CAL-3425] desination calendar of old bookings changes when default calendar of event is updated Apr 15, 2024
@keithwillcode keithwillcode removed this from the v4.1 milestone May 9, 2024
@Shaik-Sirajuddin
Copy link
Contributor

The issue is specific to Google Calendar Integration , where the logic verifies default calendar of event to match the bookings associated calendar.

This fails the operation of calendar updating when a booking is cancelled

@Shaik-Sirajuddin
Copy link
Contributor

Shaik-Sirajuddin commented May 13, 2024 •
edited

Found that , Each event is associated with a destination calendar , when the default calendar of an event is updated , the destination calendar entry for the particular event is updated.
Destination Calendar seems directly not associated with Booking , a externalD field is available in booking reference which remains unchanged by the modification of events default calendar.

externalID from booking reference is used while deleting an calendars event , except in case of google calendar where an additional logic is in place.

@Shaik-Sirajuddin Shaik-Sirajuddin linked a pull request May 13, 2024 that will close this issue
Open
3 tasks
@dosubot dosubot bot added this to the v4.2 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync linear Sync Github Issue from community members to Linear.app Medium priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
v4.2
4 participants
@keithwillcode @CarinaWolli @Shaik-Sirajuddin @Pritam-sd-dev