Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: google calendar event not deleted on updating the default calendar for a cal.com event #14994

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shaik-Sirajuddin
Copy link
Contributor

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

-Update default calendar to google calendar for an event ( account A )
-create a booking with alternative account ( account B )
-update default calendar of event to a different calendar ( account A )
( google calendar supports multiple calendar instances , a second instance can be used for update)
-cancel booking
-verify the event is deleted in google calendar ( initial calendar linked to account A ) ,
the event remains undeleted before fix.

Checklist

Copy link

vercel bot commented May 13, 2024

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label May 13, 2024
@graphite-app graphite-app bot requested a review from a team May 13, 2024 04:49
@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking linear Sync Github Issue from community members to Linear.app Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels May 13, 2024
Copy link
Contributor

github-actions bot commented May 13, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added the calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar label May 13, 2024
Copy link

graphite-app bot commented May 13, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/13/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/13/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@Shaik-Sirajuddin Shaik-Sirajuddin changed the title fix : google calendar event not deleted on updating the default calendar for a cal.com event fix: google calendar event not deleted on updating the default calendar for a cal.com event May 13, 2024
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode added this to the v4.2 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar community Created by Linear-GitHub Sync linear Sync Github Issue from community members to Linear.app Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3425] desination calendar of old bookings changes when default calendar of event is updated
2 participants