-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken url on booking page #15028
Conversation
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
{ | ||
// We don't want booker to be able to see the list of other users or teams inside the embed | ||
href: isEmbed ? null : getBookerBaseUrlSync(entity.orgSlug), | ||
image: profile.image || "", | ||
alt: profile.name || "", | ||
title: profile.name || "", | ||
}, | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was only meant for org event types and not normal event types
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/14/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 8 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/23/2024 04:16:44pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 40f2764 Started: 05/23/2024 04:15:12pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0.45% (1)1 / 224 runfailed over last 7 days |
33.93% (76)76 / 224 runsflaked over last 7 days |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're having merge conflicts now. @Udit-takkar Can you take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a blocking comment otherwise it is good.
Approved but let's add a test for this in a follow-up |
What does this PR do?
Regression from https://github.com/calcom/cal.com/pull/14777/files.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?