-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Invalid phone error on prefill with plus(+) sign #15046
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hariombalhara and the rest of your teammates on Graphite |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 34 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/17/2024 01:29:52pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 141a9c6 Started: 05/17/2024 01:28:10pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Update Profile Can update a users email (verification enabled)
Retry 2 • Retry 1 • Initial Attempt |
39.85% (104)104 / 261 runsfailed over last 7 days |
31.80% (83)83 / 261 runsflaked over last 7 days |
packages/features/bookings/lib/getBookingResponsesSchema.test.ts
Outdated
Show resolved
Hide resolved
} else if (field.type === "phone") { | ||
// + in URL could be replaced with space, so we need to replace it back | ||
// Replace the space(s) in the beginning with + as it is supposed to be provided in the beginning only | ||
newResponses[field.name] = value.replace(/^ +/, "+"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'+' in RegExp is a special character by default. So, it isn't replacing' +'. It is replacing '1 or more spaces'
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/16/24)1 reviewer was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What does this PR do?
Loom showing it is fixed
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
phone=+919999999999