Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate the llama3 (8B, 70B) served by Groq #531

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

feat: integrate the llama3 (8B, 70B) served by Groq #531

wants to merge 22 commits into from

Conversation

Appointat
Copy link
Member

@Appointat Appointat commented Apr 24, 2024 •
edited

Description

Describe your changes in detail.

Motivation and Context

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • New feature (non-breaking change which adds core functionality)
  • Example (update in the folder of example)

@Appointat Appointat marked this pull request as draft April 24, 2024 18:34
@Appointat Appointat changed the title feat: integrate the llama3 (8B, 70B) served by LLama3 feat: integrate the llama3 (8B, 70B) served by Groq Apr 24, 2024
@Appointat Appointat self-assigned this Apr 24, 2024
@Appointat Appointat added the Model Related to backend models label Apr 24, 2024
@camel-ai camel-ai deleted a comment from coderabbitai bot Apr 24, 2024
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 27, 2024 •
edited

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Wendong-Fan Wendong-Fan added this to the Sprint 2 milestone Apr 28, 2024
@Wendong-Fan Wendong-Fan linked an issue Apr 28, 2024 that may be closed by this pull request
[Feature Request] Integration of Llama 3 from Groq cloud API #520
Open
2 tasks
@Appointat Appointat marked this pull request as ready for review April 28, 2024 16:05
@Appointat
Copy link
Member Author

@Wendong-Fan Hi, could you please help me add GROQ_API_KEY to the GitHub secret (I will DM you the secrete key value)? Thanks a lot in advance.

@Wendong-Fan Wendong-Fan requested a review from a team April 29, 2024 11:53
ocss884
ocss884 reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@ocss884 ocss884 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a question

camel/models/groq_model.py Outdated Show resolved Hide resolved
@Appointat Appointat requested a review from a team April 30, 2024 22:16
Wendong-Fan
Wendong-Fan reviewed May 6, 2024
View reviewed changes
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Appointat 's contribution! Overall is great, left some comments

camel/models/__init__.py Outdated Show resolved Hide resolved
camel/utils/token_counting.py Outdated Show resolved Hide resolved
camel/models/groq_model.py Outdated Show resolved Hide resolved
camel/models/groq_model.py Outdated Show resolved Hide resolved
ocss884
ocss884 reviewed May 7, 2024
View reviewed changes
Copy link
Member

@ocss884 ocss884 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

camel/utils/token_counting.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocss884 ocss884 ocss884 left review comments

@Wendong-Fan Wendong-Fan Wendong-Fan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@Appointat Appointat

Labels
Model Related to backend models
Projects
Project Camel
Status: Reviewed
Milestone
Sprint 2
Development

Successfully merging this pull request may close these issues.

[Feature Request] Integration of Llama 3 from Groq cloud API
3 participants
@Appointat @ocss884 @Wendong-Fan