Adapted to the Ascend NPU #3933
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
lededev
reviewed
May 5, 2024
| @@ -512,25 +512,28 @@ def _get_proxies(): | |||
| def detect_device() -> Literal["cuda", "mps", "cpu"]: | |||
| try: | |||
| import torch | |||
| import mindspore as ms | |||
There was a problem hiding this comment.
第515行的import放在520行前面要好些，用cuda和mps的用户不需要引入这个mindspore就直接返回了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
对当前0.2.10版本进行昇腾NPU适配，其中Fastchat已由官方Repo适配过，本次commit适配了以下内容：
1、embedding model部分支持NPU加载
2、以及可选device支持NPU