-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add LogPosition and CollectionVersion to Segment database model #2070
base: liquan_cache_invalidation_proto
Are you sure you want to change the base?
[ENH] Add LogPosition and CollectionVersion to Segment database model #2070
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Ishiihara and the rest of your teammates on Graphite |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
e3a5883
to
52dec21
Compare
65206f1
to
46b770f
Compare
52dec21
to
2ff4cc4
Compare
CreatedAt time.Time `gorm:"created_at;type:timestamp;not null;default:current_timestamp"` | ||
UpdatedAt time.Time `gorm:"updated_at;type:timestamp;not null;default:current_timestamp"` | ||
FilePaths map[string][]string `gorm:"file_paths;serializer:json;default:'{}'"` | ||
LogPosition int64 `gorm:"log_position;default:0"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should think a little carefully about this change and its implications. Do we want to implictly preserve the contract that this advances in lockstep with collections log position?
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?