Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Use statefulset for query and compaction services #2191

Merged
merged 4 commits into from
May 17, 2024

Conversation

Ishiihara
Copy link
Contributor

@Ishiihara Ishiihara commented May 13, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • This PR makes the following changes:
      • The SysDb now publishes the pod name instead of the pod IP in the memberlist.
      • The compaction and query services are using a Statefulset instead of Deployment to reduce assignment shuffle.
      • Removed the pattern check in the memberlist CRD that only allow valid IPs.
      • Change the compaction and query services configuration from my_ip to my_member_id.
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 4:50pm

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Ishiihara and the rest of your teammates on Graphite Graphite

@Ishiihara Ishiihara changed the title [ENH] Use stateful set for query and compaction services [ENH] Use statefulset for query and compaction services May 13, 2024
@Ishiihara Ishiihara force-pushed the liquan_memberlist_statefulset branch from 5697495 to f5aa1dd Compare May 13, 2024 20:46
@Ishiihara Ishiihara force-pushed the liquan_memberlist_statefulset branch from f5aa1dd to 02ad97b Compare May 14, 2024 17:46
@Ishiihara Ishiihara marked this pull request as ready for review May 14, 2024 18:41
@Ishiihara Ishiihara requested review from HammadB and beggers May 14, 2024 18:41
@Ishiihara Ishiihara self-assigned this May 14, 2024
@HammadB
Copy link
Collaborator

HammadB commented May 15, 2024

Looks good overall - can we patch the broken test and then I can rereview?

@Ishiihara Ishiihara merged commit 6c088cd into main May 17, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants