[BUG] Count should handle uninit'ed segments

[HammadB]

Description of changes

Summarize the changes made by this PR.

• Improvements & Bug fixes
  • Count should handle uninit'ed segments
• New functionality
  • None

Test plan

How are these changes tested?
#2185 should add tests for the count() operator

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
chroma	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 14, 2024 5:14pm

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[sanketkedia]

This is incorrect. In this case, the count should be the count from the logs and not 0. My 2c is to do it correctly now instead of deferring

[HammadB]

oh woops :). you are correct! my bad

[HammadB]

Hm actually no. I don't think this is wrong. The calling code adds the log count in.

chroma/rust/worker/src/execution/orchestration/metadata.rs

Line 421 in cf7ad5c

match channel.send(Ok(msg.count + self.log_record_count)) {

I think in #2185 you change the structure which makes the comment above relevant.

Would you prefer I wait that is landed and merge accordingly?

[sanketkedia]

Yes, you are correct. I had #2185 in mind when making this comment. I had mentally merged the two PRs in my mind (since that is what would've happened when resolving conflicts). I think we should wait for that to be landed