Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip flashes while clicking toolbar items #16331

Merged
merged 1 commit into from
May 20, 2024
Merged

Tooltip flashes while clicking toolbar items #16331

merged 1 commit into from
May 20, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented May 9, 2024

Suggested merge commit message (convention)

Internal (ui): Ensure tooltips are not pinned when the element is not being hovered over.


Additional information

  1. Marked as internal - it's not regression. The issue was introduced in commit that hasn't been released yet.
  2. Closes Tooltip flashes while clicking toolbar items #16383

Video

Before:

tooltip-issue-before.mp4

After:

tooltip-hover-issue-after-2024-05-20_07.28.38.mp4

@Mati365 Mati365 requested review from oleq and scofalik May 9, 2024 13:11
Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine. Let the QA team double-check it because this whole system seems very fragile.

@scofalik scofalik closed this May 15, 2024
@scofalik scofalik reopened this May 15, 2024
@scofalik
Copy link
Contributor

Part of what was proposed in this PR was already merged to release: #16363.

My question is about this part of this PR:

What does it do? Does it actually fix something or is it unnecessary change (as the other part of the PR fixes the original issue). The unit test unfortunately does not say much about a use case. So, I don't know if this PR should be closed or whether the extended if actually is meaningful.

@Mati365 Mati365 marked this pull request as draft May 16, 2024 12:31
@ckeditor ckeditor deleted a comment from coderabbitai bot May 20, 2024
@Mati365 Mati365 marked this pull request as ready for review May 20, 2024 05:38
@Mati365
Copy link
Member Author

Mati365 commented May 20, 2024

@scofalik I created an GH issue that shows how to reproduce this issue and added short explanation above if statement in the code. Can you take a look again?

@Mati365 Mati365 requested a review from Reinmar May 20, 2024 05:47
@Mati365 Mati365 changed the title Instant pin tooltip on focus only if not hovered Tooltip flashes while clicking toolbar items. May 20, 2024
@Mati365 Mati365 added release:blocker This issue blocks the upcoming release (is critical). release:potential-blocker This issue potentially blocks the upcoming release (should be checked). and removed release:potential-blocker This issue potentially blocks the upcoming release (should be checked). labels May 20, 2024
@Mati365 Mati365 requested a review from oleq May 20, 2024 05:49
@scofalik scofalik changed the title Tooltip flashes while clicking toolbar items. Tooltip flashes while clicking toolbar items May 20, 2024
@scofalik
Copy link
Contributor

LGTM. Did QA test that one already?

@Mati365
Copy link
Member Author

Mati365 commented May 20, 2024

Yep, it was tested

@scofalik scofalik merged commit 54d43e1 into master May 20, 2024
6 checks passed
@scofalik scofalik deleted the ck/6219 branch May 20, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker This issue blocks the upcoming release (is critical).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip flashes while clicking toolbar items
3 participants