-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip flashes while clicking toolbar items #16331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine. Let the QA team double-check it because this whole system seems very fragile.
Part of what was proposed in this PR was already merged to My question is about this part of this PR: What does it do? Does it actually fix something or is it unnecessary change (as the other part of the PR fixes the original issue). The unit test unfortunately does not say much about a use case. So, I don't know if this PR should be closed or whether the extended |
LGTM. Did QA test that one already? |
Yep, it was tested |
Suggested merge commit message (convention)
Internal (ui): Ensure tooltips are not pinned when the element is not being hovered over.
Additional information
internal
- it's not regression. The issue was introduced in commit that hasn't been released yet.Video
Before:
tooltip-issue-before.mp4
After:
tooltip-hover-issue-after-2024-05-20_07.28.38.mp4