-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IndexJoin
/JoinInner
: store ColId
#1166
Open
Centril
wants to merge
3
commits into
master
Choose a base branch
from
centril/index-join-inner-colid
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/simplify-fieldname
branch
from
April 26, 2024 13:14
3b9f299
to
af99b17
Compare
Centril
force-pushed
the
centril/index-join-inner-colid
branch
from
April 26, 2024 13:53
a5cb106
to
cac1c01
Compare
Centril
force-pushed
the
centril/simplify-fieldname
branch
from
April 26, 2024 16:23
af99b17
to
5b5274a
Compare
Centril
force-pushed
the
centril/index-join-inner-colid
branch
from
April 26, 2024 16:31
cac1c01
to
8d9a0f9
Compare
Centril
force-pushed
the
centril/simplify-fieldname
branch
from
April 26, 2024 16:40
5b5274a
to
dc59598
Compare
Centril
changed the title
Apr 26, 2024
IndexJoin
/JoinInner
: store ColId
; incr-join
perf -21.419%
IndexJoin
/JoinInner
: store ColId
; incr-join
perf -20.511%
Centril
force-pushed
the
centril/index-join-inner-colid
branch
from
April 26, 2024 16:46
8d9a0f9
to
14e2652
Compare
Centril
force-pushed
the
centril/simplify-fieldname
branch
from
April 26, 2024 17:08
dc59598
to
1ce322c
Compare
Centril
force-pushed
the
centril/index-join-inner-colid
branch
from
April 26, 2024 17:22
14e2652
to
28b0725
Compare
Centril
force-pushed
the
centril/index-join-inner-colid
branch
from
April 30, 2024 20:58
28b0725
to
70da3b8
Compare
Centril
force-pushed
the
centril/index-join-inner-colid
branch
4 times, most recently
from
May 7, 2024 17:32
2280723
to
9e24533
Compare
Centril
changed the title
May 7, 2024
IndexJoin
/JoinInner
: store ColId
; incr-join
perf -20.511%
IndexJoin
/JoinInner
: store ColId
Centril
force-pushed
the
centril/index-join-inner-colid
branch
4 times, most recently
from
May 13, 2024 09:17
5bc3f77
to
8ca55bf
Compare
This was referenced May 13, 2024
Oh, I see. I missed the fact that the row in question is not within the range. |
If we had |
Centril
force-pushed
the
centril/index-join-inner-colid
branch
from
May 24, 2024 15:37
8ca55bf
to
a53bb88
Compare
Centril
force-pushed
the
centril/index-join-inner-colid
branch
from
May 30, 2024 23:48
a53bb88
to
72b74e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
ColId
inIndexJoin
andJoinInner
as opposed toFieldName
. This avoids queryingHeader
inbuild_query
.Header
s for inner joins and projections.QueryExpr::head
now provides the end-result header for the entire query, which is the same header as you'd get frombuild_query
. This means that we can eventually stop making aHeader
inbuild_query
and thereby move more runtime to query compilation and spend less in query building / evaluation.build_query
functions.API and ABI breaking changes
None
Expected complexity level and risk
2