Change deployment > model in CLI #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lusmoura
reviewed
Apr 29, 2024
| @@ -14,8 +14,8 @@ class bcolors: | |||
|
|
|||
|
|
|||
| """ | |||
| To add a new deployment, add a new DeploymentName enum and a new entry in the DEPLOYMENTS dictionary containing the secrets required for the deployment. | |||
| If the deployment requires a custom implementation, add a new key "custom_implementation" with the function that will be called to set up the deployment. | |||
| To add a new model, create a new DeploymentName enum and a new entry in the DEPLOYMENTS dictionary containing the secrets required for the model deployment. | |||
There was a problem hiding this comment.
Should we default to calling it model deployment? It might be confusing to refer to this by model or by deployment separately
tianjing-li
requested changes
May 1, 2024
|
Closing as its out of date now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Cohere Toolkit!
Change deployment > model in CLI: "main.cli: mentions of deployment updated to be 'model'"
Users were getting confused by deployment being required, thinking that it was the app deployment. updates description to clarify that users should select a model in order for the app to work.
PR message:
Add tests and docs: Please include testing and documentation for your changes
Lint and test: Run
make lintandmake run-tests