Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Removed setup only dependency for makefile #95

Closed
wants to merge 1 commit into from

Conversation

samuelzxu
Copy link

@samuelzxu samuelzxu commented May 3, 2024

Thank you for contributing to the Cohere Toolkit!

  • PR title: Bugfix: Removed setup only dependency for makefile

  • PR message: I've tried to install for debian 12 using the linux friendly instructions in the quickstart and the option 2 installation instructions. However, the make setup or make first-run commands fail with dependency errors for transformers and llama_cpp. I think this is because of the --only setup restriction in Makefile, which could restrict the dependency installs from pyproject.toml solely to setup dependencies rather than all dependencies.

    • Description: Removes the setup-only restriction
    • Dependencies: none

@samuelzxu samuelzxu requested a review from a team as a code owner May 3, 2024 21:16
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@samuelzxu samuelzxu changed the title Removed setup only dependency for makefile Bugfix: Removed setup only dependency for makefile May 3, 2024
@tianjing-li
Copy link
Collaborator

tianjing-li commented May 3, 2024

Can I get more context on the issue? The initial poetry install with --only setup installs those dependencies on your local host machine to run the main.py CLI script, however make migrate and make dev should build the docker images for you, which runs

RUN pip install --no-cache-dir poetry==1.6.1 && \
poetry install --without setup

to install all dependencies.

Crucially, I'd like to know if the proposed fix resolves your issue

@samuelzxu
Copy link
Author

The problem that I had was that the make setup script didn't run. It resulted in transformers and llama_cpp dependency errors. After removing the --only setup flag, the script run without errors.

@tianjing-li
Copy link
Collaborator

Hey @samuelzxu, the Makefile has been updated since the creation of this PR, I'll close this for now but if you're running into issues with the current make commands feel free to creating a new issue/PR as needed, thanks!

@tianjing-li tianjing-li closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants