Fix msys ORIGINAL_PATH confusion #16269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure ORIGINAL_PATH is unset, so msys's /etc/profile will use the previous PATH as the future PATH.
|
Hi @paulharris Could you please have a look to the suggestion in #16268 (comment)? |
|
Thanks for the prod, I'll give it a test in the next few days
…On Thu, 30 May 2024, 6:55 pm James, ***@***.***> wrote:
Hi @paulharris <https://github.com/paulharris>
Could you please have a look to the suggestion in #16268 (comment)
<#16268 (comment)>?
—
Reply to this email directly, view it on GitHub
<#16269 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMSASZPVYN6FLW5ONDULBLZE4AS3AVCNFSM6AAAAABHZPO6IWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZZGI4TMMRUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sounds good, keep me posted @paulharris we plan to branch Conan 2.4 on Monday |
|
Your suggested alternative patch works for me. |
If you want to update your PR with the change, I think it is fair to get yours merged, you did most of the research, I only suggested as small location change of the place to clean the env-var. |
paulharris
force-pushed
the
fix-msys-original_path
branch
3 times, most recently
from
0b36e4c
to
4c87725
Compare
msys's /etc/profile checks and uses ORIGINAL_PATH as its PATH, instead of the PATH in the environment. We want to avoid this, and use the PATH that conan has prepared. The design is so any msys shell started within an existing msys shell will start with the original environment the first msys started with. This applies when the user runs conan from within a msys terminal, and builds a package that uses an embedded msys environment (eg AutoTools-based packages).
paulharris
force-pushed
the
fix-msys-original_path
branch
from
4c87725
to
408b291
Compare
|
There you go, sorry for force-pushes, weekend-brain. |
memsharded
approved these changes
Jun 2, 2024
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Omit
Docs: Omit
Ensure ORIGINAL_PATH is unset,
so msys's /etc/profile will use the previous PATH as the future PATH.
Refer to #16268