Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/9533 Updated TimeBoundedQueue to be bound by capacity and duration both #9693

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

gunishmatta
Copy link

@gunishmatta gunishmatta commented Nov 7, 2022

Description

Original Issue
TimeBoundedQueue has been fixed to bounded by both time and capacity

Currently, When a query has errors, a list of errors collected is displayed by the SHOW QUERIES EXTENDED or EXPLAIN commands. This list has a config to limit the number of errors displayed. The config is ksql.query.error.max.queue.size and is default to 10. However, the SHOW QUERIES command is displaying more errors than what it is configured and it keeps growing. This was due to this fix

So to prevent this, I have added a capacity member in the TimeBoundedQueue Class and in evict method, if the elements are less than capacity than only we will skip poll else we will evict out the elements, For more context refer code change.

Testing done

Have added Unit Tests for the same

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@gunishmatta gunishmatta requested a review from a team as a code owner November 7, 2022 17:53
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ ConfluentJenkins
❌ gunishmatta
You have signed the CLA already but the status is still pending? Let us recheck it.

@gunishmatta gunishmatta changed the title Fix/9533 Fix/9533 Updated TimeBoundedQueue to be bound by capacity and duration both Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants