Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some doc for shim reap orphan process #10002

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add some doc for shim reap orphan process #10002

wants to merge 1 commit into from
+7 −0

Conversation

ningmingxiao
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link

Hi @ningmingxiao. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fuweid
fuweid reviewed Mar 27, 2024
View reviewed changes
core/runtime/v2/README.md Outdated Show resolved Hide resolved
fuweid
fuweid requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please sign it off by git commit -s --amend. thanks

@ningmingxiao
Copy link
Contributor Author

please sign it off by git commit -s --amend. thanks

done

@ningmingxiao ningmingxiao force-pushed the shim_doc branch 4 times, most recently from 05d0d08 to 01e7bf5 Compare March 27, 2024 03:28
@fuweid fuweid self-assigned this Apr 2, 2024
@ningmingxiao ningmingxiao mentioned this pull request Apr 7, 2024
Open
fuweid
fuweid reviewed Apr 19, 2024
View reviewed changes
core/runtime/v2/README.md Outdated Show resolved Hide resolved
@fuweid
Copy link
Member

fuweid commented Apr 19, 2024

ping @ningmingxiao sorry for late reply. Added my comment, PTAL. Thanks

@fuweid fuweid mentioned this pull request Apr 19, 2024
Open
@ningmingxiao ningmingxiao force-pushed the shim_doc branch 4 times, most recently from 0fd6830 to ca6fd34 Compare May 30, 2024 09:50
@ningmingxiao
Copy link
Contributor Author

ping @ningmingxiao sorry for late reply. Added my comment, PTAL. Thanks

done.thank you

@ningmingxiao ningmingxiao force-pushed the shim_doc branch 2 times, most recently from 30efca9 to 2cbf741 Compare May 30, 2024 11:04
@ningmingxiao
add some doc for shim reap orphan process
8c1c113 
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@fuweid fuweid

Labels
needs-ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ningmingxiao @k8s-ci-robot @fuweid