fix: limit execution in gov #20348
fix: limit execution in gov #20348
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
x/gov/README.md
Outdated
|
|
||
| Execution is the process of executing the messages contained in a proposal. The execution phase will commence after the proposal has been accepted by the network. The messages contained in the proposal will be executed in the order they were submitted. | ||
|
|
||
| Execution has a upper limit on how many messages can be executed in a single block. This limit is defined by the `MaxMessagesPerProposal` parameter. We use the MaxBlockGas from the consensus engine, value stored in the consensus module, to calculate the limit of messages that can be executed in a block. |
There was a problem hiding this comment.
Why do we need a MaxMessagesPerProposal if we already have that block gas limit?
| @@ -193,26 +194,31 @@ | |||
| // Messages may mutate state thus we use a cached context. If one of | |||
| // the handlers fails, no state mutation is written and the error | |||
| // message is logged. | |||
| if err := k.BranchService.Execute(ctx, func(ctx context.Context) error { | |||
| params, err := k.Params.Get(ctx) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
x/gov/keeper/abci.go
Outdated
| _, err = k.BranchService.ExecuteWithGasLimit(ctx, params.ProposalExecutionGas, func(ctx context.Context) error { | ||
| // execute all messages | ||
| for idx, msg = range messages { | ||
| if _, err := safeExecuteHandler(ctx, msg, k.MsgRouterService); err != nil { | ||
| // `idx` and `err` are populated with the msg index and error. | ||
| proposal.Status = v1.StatusFailed | ||
| proposal.FailedReason = err.Error() | ||
| tagValue = types.AttributeValueProposalFailed | ||
| logMsg = fmt.Sprintf("passed, but msg %d (%s) failed on execution: %s", idx, sdk.MsgTypeURL(msg), err) | ||
|
|
||
| return err | ||
| } | ||
| } | ||
|
|
||
| proposal.Status = v1.StatusPassed | ||
| tagValue = types.AttributeValueProposalPassed | ||
| logMsg = "passed" | ||
|
|
||
| return nil | ||
| }); err != nil { | ||
| }) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
Description
limit execution of gov proposals to infinite messages.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...