Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Proxy return redirect response #586

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

reginbald
Copy link
Contributor

@reginbald reginbald commented May 14, 2024

What has been changed

Configures proxy to not follow redirects and return to the client the actual response from the server.

Why?

Current proxy solution "follows" redirect responses from the server and makes an additional request rather then returning the redirect response to the client.

Example Scenario

Client issues a delete request and the server returns a See Other redirect response. Current proxy solution does not return the response but follows the redirect response, makes another request and then returns that response to the client.

Before the change:

image image

After the change:

image image

@reginbald reginbald changed the title Don't follow redirects Fix: Proxy return redirect response May 14, 2024
@reginbald
Copy link
Contributor Author

reginbald commented May 14, 2024

Hey @cosmtrek, @ndajr or @xiantang do you have time to review this PR? Any thoughts?

@ndajr
Copy link
Contributor

ndajr commented May 23, 2024

Hi @reginbald, sorry for the delay. Looks good to me! I will try to reach @xiantang and see if we can release these three PRs together in the next minor release:

@xiantang
Copy link
Collaborator

Tks. well done

@xiantang xiantang merged commit 9f85057 into cosmtrek:master May 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants