chore(cubesql): Fix rounding error in reuse params test query #8278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MazterQyou
force-pushed
the
cubesql/fix-testing-query
branch
from
e2591bd
to
e966008
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
MazterQyou
force-pushed
the
cubesql/fix-testing-query
branch
from
e966008
to
35c86fe
Compare
MazterQyou
force-pushed
the
cubesql/fix-testing-query
branch
from
35c86fe
to
4ac8b18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR fixes an issue in
cubejs-testing-driverswith the newly introduced reuse params query test, wrapping the result of the sum in aROUNDfunction, preventing rounding errors.