Upgrade React and Antd till the latest version #7466
Conversation
|
/check |
|
❌ Some checks failed |
bsekachev
changed the title
<!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://opencv.github.io/cvat/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> This is a preparatory PR before I add more events. ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - ~~[ ] I have created a changelog fragment~~ <!-- see top comment in CHANGELOG.md --> - ~~[ ] I have updated the documentation accordingly~~ - ~~[ ] I have added tests to cover my changes~~ - ~~[ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))~~ - ~~[ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))~~ ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern.
By default failed rq jobs are kept for 1 year. It is too long and leads to keeping a lot of unnecessary results in Redis.
…ansaction (#7460) Non-database actions like deleting directories, sending webhooks, scheduling reports should only be done after the current transaction is committed. If we do it immediately, and the transaction is later aborted, then we will have (for example) sent a webhook about an event that didn't actually happen. There's also a secondary benefit to moving this action outside of the transaction; the less time we spend inside a transaction, the better, since a transaction may lock out other clients from working on the affected DB rows. In addition, prevent the affected actions from crashing the view handler with an exception (using the `robust=True` option). I don't think it's reasonable to (for example) return a 500 response to a `PATCH` request just because we failed to send the corresponding webhook. There is one more type of action that should be modified in this way (sending events), but it would be easier to do that after a refactoring that I did in another patch, so I'll do it later.
cvat-ui/src/components/annotation-page/standard-workspace/objects-side-bar/object-item.tsx
Show resolved
Hide resolved
cvat-ui/src/components/annotation-page/standard-workspace/styles.scss
Outdated
Show resolved
Hide resolved
|
@klakhov Applied |
There was a problem hiding this comment.
Exclamation mark and excessive left padding now appear on organization switch modal. Also I cant close it without selecting something new
Do we really want to use blue hover effect? I think it doesn't stand out enough on gray background. Maybe we can use scaling effect instead.
Here I suppose using bold black font would be better instead of blue too.
If we dont have an assignee, maybe we dont want to show the line with it at all? Or at least say something like not assigned so we dont have emty space.
I like the idea of showing stage+state in one status row like annotation in progress or annotation rejected, it looks cool. But it looks strange with new, maybe we should use an alias for that something like annotation not started.
Small padding problem on models page(it seems the same problem is on the projects page):
Major version update for package.json?
I believe this is new antd style:
I do not see reasons to update major version. Generally all the changes are cosmetic. |
Applied
Default antd button, I reversed it as it was with custom css.
The same.
The main idea is to keep height the same. Sliding bottom part is annoying a little bit.
The main idea behind it was to keep vertical space, using horizontal free space. I would avoid customizing logic in described way.
Fixed on projects/jobs/models. Also fixed top bars on different resolutions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7466 +/- ##
===========================================
- Coverage 83.38% 83.35% -0.03%
===========================================
Files 380 381 +1
Lines 40034 40051 +17
Branches 3769 3769
===========================================
+ Hits 33382 33386 +4
- Misses 6652 6665 +13
|
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.