Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gratuitous non-ASCII characters #7683

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Mar 26, 2024

In a couple cases, remove the surrounding code too:

  • In cvat-ui/src/index.html, the meta element seems useless (the default is already to index and follow; I'm not even sure index and follow are valid values).

  • In labels-list.tsx, the code seems dead, as there is no "-" button that would trigger it.

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

In a couple cases, remove the surrounding code too:

* In `cvat-ui/src/index.html`, the meta element seems useless (the default
  is already to index and follow; I'm not even sure `index` and `follow` are
  valid values).

* In `labels-list.tsx`, the code seems dead, as there is no "-" button that
  would trigger it.
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Merging #7683 (eb5e954) into develop (f513aa1) will decrease coverage by 0.06%.
Report is 23 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7683      +/-   ##
===========================================
- Coverage    83.47%   83.41%   -0.06%     
===========================================
  Files          373      373              
  Lines        39739    39722      -17     
  Branches      3741     3741              
===========================================
- Hits         33171    33135      -36     
- Misses        6568     6587      +19     
Components Coverage Δ
cvat-ui 79.27% <ø> (-0.02%) ⬇️
cvat-server 87.24% <100.00%> (-0.09%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant