Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC2024] Added additional security headers #7752

Merged
merged 12 commits into from May 20, 2024
Merged

Conversation

mach-12
Copy link
Contributor

@mach-12 mach-12 commented Apr 11, 2024

Added security headers for Referrer-Policy, X-Content-Type-Options, Content-Security-Policy.

Motivation and context

Referring to Issue #7398, Added additional security headers. Added to address the deduction in security score rating third party scanners.

  • Referrer-Policy "strict-origin-when-cross-origin";: Limit the referrer information sent when a user navigates away from the website

  • X-Content-Type-Options "nosniff";: Prevent browsers from attempting to MIME-sniff the content type of a response to reduce risk of XSS and Content Injection

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features
    • Enhanced security with the addition of strict Referrer-Policy headers for cross origins.
    • Disabled MIME type sniffing via X-Content-Type-Options headers.

mach-12 and others added 8 commits March 17, 2024 20:41
Added headers for:
X-Frame-Options, Referrer-Policy, X-Content-Type-Options, Content-Security-Policy
Added headers for:
X-Frame-Options, Referrer-Policy, X-Content-Type-Options, Content-Security-Policy
Removed the CSP implemented
Removed the CSP implemented
@mach-12
Copy link
Contributor Author

mach-12 commented Apr 11, 2024

@SpecLad Have done the proposed changes

cvat-ui/react_nginx.conf Outdated Show resolved Hide resolved
cvat/nginx.conf Outdated Show resolved Hide resolved
changelog.d/20240319_014508_mann.compi.md Outdated Show resolved Hide resolved
mach-12 and others added 3 commits April 15, 2024 21:08
Made it more descriptive

Co-authored-by: Roman Donchenko <rdonchen@outlook.com>
changed the configuration for referrer policy

Co-authored-by: Roman Donchenko <rdonchen@outlook.com>
Copy link
Contributor

coderabbitai bot commented May 20, 2024

Walkthrough

This update enhances security by adding Referrer-Policy and X-Content-Type-Options headers to the server configurations in the cvat-ui/react_nginx.conf and cvat/nginx.conf files, ensuring that cross-origin referrer information is restricted and MIME type sniffing is disabled.

Changes

Files Change Summary
changelog.d/20240319_014508_mann.compi.md Introduced security enhancements by adding strict Referrer-Policy headers and disabling MIME type sniffing via X-Content-Type-Options.
cvat-ui/react_nginx.conf Updated the server configuration to include Referrer-Policy and X-Content-Type-Options headers.
cvat/nginx.conf Added add_header directives in the http block to set Referrer-Policy and X-Content-Type-Options headers.

Assessment against linked issues

Objective (Issue #7398) Addressed Explanation
Ensure Referrer-Policy header is present in responses
Ensure X-Content-Type-Options header is present in responses

In the code's embrace, security's light,
Headers now guard with all their might.
Referrer-Policy stands tall and clear,
MIME sniffing's end is finally here.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 90d5e1f and 5c0f80e.
Files selected for processing (3)
  • changelog.d/20240319_014508_mann.compi.md (1 hunks)
  • cvat-ui/react_nginx.conf (1 hunks)
  • cvat/nginx.conf (1 hunks)
Files skipped from review due to trivial changes (3)
  • changelog.d/20240319_014508_mann.compi.md
  • cvat-ui/react_nginx.conf
  • cvat/nginx.conf

@SpecLad SpecLad merged commit 146e188 into cvat-ai:develop May 20, 2024
32 checks passed
@SpecLad
Copy link
Contributor

SpecLad commented May 20, 2024

Thank you for the contribution.

FYI, I unlinked this PR from #7398. I'd like to keep that issue open, since we haven't implemented Content-Security-Policy yet.

@cvat-bot cvat-bot bot mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants