Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatic tag annotation support #7839

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

omerferhatt
Copy link

@omerferhatt omerferhatt commented May 2, 2024

Motivation and context

Since the lambda function's return objectType is always assumed to be SHAPE, the tag object cannot be passed, and it throws an error like in #6220 (comment).

Adding "objectType": "tag" next to "type": "tag" key-value pair to the lambda function fixed this problem.

How has this been tested?

Classifier serverless function PR will be sent too.

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features

    • Enhanced object detection capabilities in the annotation tool, allowing for more specific categorization of detected shapes based on their object type.
  • Refactor

    • Improved handling of object types in the annotation tool's user interface, ensuring more reliable and intuitive usage.

Copy link
Contributor

coderabbitai bot commented May 2, 2024

Walkthrough

The recent updates involve refining the handling of object types in the CVAT application. Specifically, the modifications include enhancing the DetectedShape interface to accommodate an optional objectType and updating the ToolsControlComponent to dynamically assign objectType based on available data, ensuring more flexible and accurate annotations.

Changes

File Path Change Summary
cvat-core/src/.../lambda-manager.ts Added ObjectType to imports and introduced objectType to DetectedShape interface.
cvat-ui/src/.../tools-control.tsx Updated objectType property assignment in ToolsControlComponent to use dynamic data.

🐰✨
Oh hark! A change does come,
In the land of code where rabbits roam.
ObjectType now joins the fray,
In shapes and tools, it finds its way.
Hop and code, the day is bright,
With every line, we make it right! 🌟


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between ce5e07c and 841323d.
Files selected for processing (2)
  • cvat-core/src/lambda-manager.ts (2 hunks)
  • cvat-ui/src/components/annotation-page/standard-workspace/controls-side-bar/tools-control.tsx (1 hunks)
Additional comments not posted (2)
cvat-core/src/lambda-manager.ts (1)

25-25: The addition of the optional objectType property to the DetectedShape interface aligns well with the PR's objectives to handle different object types more flexibly.

cvat-ui/src/components/annotation-page/standard-workspace/controls-side-bar/tools-control.tsx (1)

1248-1248: The logic to dynamically set objectType based on the provided data or default to ObjectType.SHAPE is a critical enhancement for supporting different object types in the UI.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@omerferhatt omerferhatt changed the title [WiP] Semi-auto tag annotation support Fix automatic `tag' annotation support May 2, 2024
@omerferhatt omerferhatt changed the title Fix automatic `tag' annotation support Fix automatic tag annotation support May 2, 2024
@omerferhatt omerferhatt marked this pull request as ready for review May 2, 2024 21:17
@bsekachev
Copy link
Member

bsekachev commented May 7, 2024

May you please add changelog entry? scriv create --edit

Fixed

  • Wrong object type and shape used when a user runs detector online to classify images

Example files may be found here: https://github.com/cvat-ai/cvat/tree/develop/changelog.d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants