-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add multi-lang IDE integration page #7378
docs: Add multi-lang IDE integration page #7378
Conversation
Some thoughts:
|
@helderco please see if my edits address your feedback. Thanks! |
This goes without saying that the IDE integrations page needs to go after the user creates their first function, but I assume it's placed the way it is because the nav is in flux due to the pending PRs. The problem with the multiple PRs here is that it puts the docs in an unpublished state in main. Would have made sense to merge PRs against a larger PR for the broader effort, while still keeping the individual reviewable changesets. There's a few things to correct in Python as only pip needs to manually create and activate the venv for example, but I'll need a bit more time to suggest specific changes. Few more notes:
|
9185534
to
7d504e3
Compare
I've made this change, will wait to have more notes from you on this.
Added
I'm not sure what change is needed here, can you suggest inline?
I think it's fine here, I'd like to keep the language-specific category as thin as possible. |
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
Signed-off-by: Vikram Vaswani <vikram@dagger.io>
d42d7b7
to
b09a714
Compare
No description provided.