[ui] Component injection site for run metrics #21998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengotow
force-pushed
the
bengotow-2024-05/FE-321
branch
from
050d686
to
340a528
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 340a528. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Related: FE-321
This PR adds a new InjectedComponent and uses it in the run actions menu and run header menu. When a component for the dialog is provided (only in Plus atm), the menu item appears and allows the dialog to be displayed.
How I Tested These Changes
Tested that this has no impact in OSS and appears in Dagster Plus.