dbt cli get_error() #21999
Merged
dbt cli get_error() #21999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rexledesma
previously requested changes
May 21, 2024
| @@ -656,6 +656,45 @@ def is_successful(self) -> bool: | |||
|
|
|||
| return self.process.wait() == 0 | |||
|
|
|||
| @public | |||
| def get_error(self) -> Optional[Exception]: | |||
There was a problem hiding this comment.
Perhaps:
Suggested change
| def get_error(self) -> Optional[Exception]: | |
| def raise_on_error(self) -> NoReturn: |
- Make it raise a
DagsterInvariantExceptionor something if a user tries to retrieve an error from a successful invocation - Otherwise
raiseinstead ofreturn - Since this function is guaranteed to
NoReturn, then we should force it consume the entire event stream before return so we give the most verbose error, with error logs parsed.
There was a problem hiding this comment.
I like this suggestion except for raising the DagsterInvariantException. NoReturn is cool but the name to implies a no-op if there's no error.
There was a problem hiding this comment.
This name would also conflict with the current raise_on_error: bool property
johannkm
force-pushed
the
johann/05-21-dbt_cli_get_error_
branch
2 times, most recently
from
feef73a
to
4c15b0f
Compare
johannkm
dismissed
rexledesma’s stale review
updated to always wait() so we have more context in all error messages
rexledesma
approved these changes
May 22, 2024
johannkm
force-pushed
the
johann/05-21-dbt_cli_get_error_
branch
from
4c15b0f
to
ed0a029
Compare
johannkm
force-pushed
the
johann/05-21-dbt_cli_get_error_
branch
from
ed0a029
to
c626576
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
dbt.cli(..., raise_on_error=False), users may still want to retrieve the error that would have been raised._errorsis private, so they couldn't put this together themselves either.