Replace nginx with Caddy #1315
Open
Replace nginx with Caddy #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markbotterill is attempting to deploy a commit to the Danswer Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to replace nginx with Caddy. Caddy requires fewer files to operate, is easier to get started with and performs similarly to nginx for most use cases.
The primary query I had about this PR was to do with global variables: In the Caddyfile, Caddy expects to see a domain name (without
https://proceeding it) but theweb_serverrequires the full URL for things like Oauth re-directs. My current solution was the addition of the $DOMAIN variable (which is then used in the $WEB_DOMAIN variable) and this can be found in theenv.prod.templatebut may not be best practice. Very open to feedback :)Cheers!