Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert Color in Query plan's treeView #33040

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

hwany7seo
Copy link
Contributor

  • Change color in cell to red when it is Full Scan (Table Scan)
  • Change color in cell to green when it is Index Scan

Issue : #23407
PR : #26459

We proceeded by referring to the above issues and PR.
image
image

And I wanted to display oracle as well, but the kind information seems to be different.
(I don't know if it's different for each version, but 'foregin' is not displayed until versions 9 to 11.)

I think need to add "table access" to allowedkind in OraclePlanNode
and distinguish between 'FULL SCAN' and 'NOT_FULL_TABLESCAN'.

case "table access":
                if (options.toLowerCase().equals("full")) {
                    return DBCPlanNodeKind.TABLE_SCAN;
                }
                return DBCPlanNodeKind.NOT_FULL_TABLE_SCAN;

If do this, it will display normally as shown below.
image
image

If possible, I'd like to include this in the PR as well.

- Change color in cell to red when it is Full Scan (Table Scan)
- Change color in cell to green when it is Index Scan
@hwany7seo hwany7seo marked this pull request as ready for review May 16, 2024 03:18
@E1izabeth E1izabeth linked an issue May 16, 2024 that may be closed by this pull request
@E1izabeth
Copy link
Member

Your proposal sounds good. Yes, it might work different on different versions.
Let's add this for Oracle in a separate PR.

@MashaKorax
Copy link
Contributor

verified

@serge-rider
Copy link
Member

There are some merge conflicts. But GH doesn't say which exactly because it is fork PR.

plugins/org.jkiss.dbeaver.core/css/e4-dark_dbeaver_prefstyle.css
@hwany7seo
Copy link
Contributor Author

The conflict has been resolved.

@serge-rider serge-rider merged commit 1ea0d51 into dbeaver:devel May 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CUBRID] Insert Color in Query plan's TableView
5 participants