dbeaver/dbeaver#18437 Support of InterSystems IRIS VIEW definition #33183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To implement getViewDDL I added a plugin for InterSystems IRIS
|
Thank you for contribution. We will review it and let you know if any corrections are needed. |
E1izabeth
reviewed
May 22, 2024
LonwoLonwo
reviewed
May 22, 2024
LonwoLonwo
reviewed
May 22, 2024
| @NotNull DBRProgressMonitor monitor, | ||
| @NotNull GenericView view, | ||
| @NotNull Map<String, Object> options) throws DBException { | ||
| String sqlStatement = "SELECT View_Definition " |
There was a problem hiding this comment.
Does the Intersystem also have the table definition? And procedure? To create more methods about definitions reading. (getTableDDL, getProcedureDDL)
There was a problem hiding this comment.
Yes, it's possible to get procedure definition, list of triggers, source code for triggers. Do you think it makes sense to do this as part of this pull request? If yes -- I'll do.
There was a problem hiding this comment.
It can be just definitions. Triggers are also welcome, but you can do them in a separate PR if you want.
LonwoLonwo
reviewed
May 22, 2024
...ver.ext.intersystems/src/org/jkiss/dbeaver/ext/intersystems/model/InterSystemsMetaModel.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement getViewDDL I added a plugin for InterSystems IRIS
./build.sh was successful.