-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addition: check_snapshot_name_contract #184
base: main
Are you sure you want to change the base?
Conversation
added entry for check-snapshot-name-contract
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
=========================================
+ Coverage 0 97.95% +97.95%
=========================================
Files 0 51 +51
Lines 0 2497 +2497
Branches 0 330 +330
=========================================
+ Hits 0 2446 +2446
- Misses 0 32 +32
- Partials 0 19 +19 ☔ View full report in Codecov by Sentry. |
Hey @ryancollingwood, could you please resolve conflicts? We've modified snapshot obtention and some logic on the latest PRs. Later this week we'll release a new version, and your PR could become part of it. |
@BAntonellini resolved the conflict, although there are failing tests for |
@ryancollingwood could you merge main and try to fix such tests? |
check_snapshot_name_contract
is similar in behaviour tocheck_model_name_contract
Impacts to existing code
get_snapshots
(indbt_checkpoint/utils.py
) now returns a generator ofModel
, previously it returned a list of strings detailing the filename of snapshots. In order to evaluate the name for the snapshot additional information is needed. This has resulted in a change todbt_checkpoint/check_model_has_properties_file.py