Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix-153: Added seeds and snapshots as parent node_types #198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ronak-datatonic
Copy link
Contributor

This PR is a response to the bug #153 and introduces the following:

  • Added seeds & snapshots to parent node_types in check_model_parents_and_childs.py & check_model_parents_schema.py
  • Added seeds and snapshots to get_parent_childs function

Copy link
Collaborator

@BAntonellini BAntonellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @ronak-datatonic

Does this require an update to test_check_model_parents_and_childs and test_check_model_parents_schema?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants