Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recording types #10175

Merged
merged 4 commits into from
May 29, 2024
Merged

add recording types #10175

merged 4 commits into from
May 29, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented May 17, 2024

resolves #10240

Problem

Record operates as all or nothing.

Solution

Add option to record by types

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label May 17, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop
Copy link
Member Author

emmyoop commented May 28, 2024

Tests are failing because it needs the changes in dbt-common

Copy link
Contributor

@peterallenwebb peterallenwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving for after the supporting dbt-common changes are in place and testing passes.

@emmyoop emmyoop changed the title add new mode add recording types May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.73%. Comparing base (341803d) to head (9263ba6).
Report is 12 commits behind head on main.

Files Patch % Lines
core/dbt/cli/requires.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10175      +/-   ##
==========================================
+ Coverage   88.65%   88.73%   +0.07%     
==========================================
  Files         180      180              
  Lines       22422    22477      +55     
==========================================
+ Hits        19879    19945      +66     
+ Misses       2543     2532      -11     
Flag Coverage Δ
integration 86.07% <83.33%> (-0.07%) ⬇️
unit 63.29% <83.33%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop marked this pull request as ready for review May 29, 2024 19:52
@emmyoop emmyoop requested a review from a team as a code owner May 29, 2024 19:52
@emmyoop emmyoop merged commit d8e38c1 into main May 29, 2024
65 checks passed
@emmyoop emmyoop deleted the er/dynamic-recording branch May 29, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support specifying types for recording
2 participants