Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frustrum culling for tilemap #8935

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ekharkunov
Copy link
Contributor

@ekharkunov ekharkunov commented May 15, 2024

Fixes #6938, #8744

Technical changes

One render entry for tile map is tilemap region. So I check visibility for whole region, not for every tile. Region size now is 32x32 tiles. That's why id region partially outside of the camera frustrum - is will fully rendered.

Docs: defold/doc#435

PR checklist

  • Code
    • Add engine and/or editor unit tests.
    • New and changed code follows the overall code style of existing code
    • Add comments where needed
  • Documentation
    • Make sure that API documentation is updated in code comments
    • Make sure that manuals are updated (in github.com/defold/doc)
  • Prepare pull request and affected issue for automatic release notes generator
    • Pull request - Write a message that explains what this pull request does. What was the problem? How was it solved? What are the changes to APIs or the new APIs introduced? This message will be used in the generated release notes. Make sure it is well written and understandable for a user of Defold.
    • Pull request - Write a pull request title that in a sentence summarises what the pull request does. Do not include "Issue-1234 ..." in the title. This text will be used in the generated release notes.
    • Pull request - Link the pull request to the issue(s) it is closing. Use on of the approved closing keywords.
    • Affected issue - Assign the issue to a project. Do not assign the pull request to a project if there is an issue which the pull request closes.
    • Affected issue - Assign the "breaking change" label to the issue if introducing a breaking change.
    • Affected issue - Assign the "skip release notes" is the issue should not be included in the generated release notes.

Example of a well written PR description:

  1. Start with the user facing changes. This will end up in the release notes.
  2. Add one of the GitHub approved closing keywords
  3. Optionally also add the technical changes made. This is information that might help the reviewer. It will not show up in the release notes. Technical changes are identified by a line starting with one of these:
    1. ### Technical changes
    2. Technical changes:
    3. Technical notes:
There was a anomaly in the carbon chroniton propeller, introduced in version 8.10.2. This fix will make sure to reset the phaser collector on application startup.

Fixes #1234

### Technical changes
* Pay special attention to line 23 of phaser_collector.clj as it contains some interesting optimizations
* The propeller code was not taking into account a negative phase.

JCash
JCash previously approved these changes May 16, 2024
Copy link
Contributor

@JCash JCash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Small note about readability that might be improved.

int32_t row_count = (int32_t)resource->m_RowCount;
int32_t min_x = resource->m_MinCellX + region_x * TILEGRID_REGION_SIZE;
int32_t min_y = resource->m_MinCellY + region_y * TILEGRID_REGION_SIZE;
int32_t max_x = dmMath::Min(min_x + (int32_t)TILEGRID_REGION_SIZE, resource->m_MinCellX + column_count);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will column_count ever be < 1?
And even if it is, we can set it to 1?
I feel that the two cases inside Min() are a bit tricky to read. One uses "min_x", and the other uses "m_MinCellX".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

column_count can not be < 1. I cast all unsigned type to signed because at last step here https://github.com/defold/defold/pull/8935/files/fa8d2d61102b20660bcee6144fba1c7e79b6ef4d#diff-840abe2ff7226d24a7cc3b2884131009a9cc28f9a062011b163f31a83c1608ebR661-R662 I ran into issue that signed min_... that < 0 cast to unsigned and I got very huge number. That why I converted all variables to signed types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frustum culling for tilemaps
2 participants