test(ext/net): check network types with Fresh, Oak and std/http
#23705
Conversation
|
@dsherret, I want to make actual JSR requests here. Should the spec tests allow me to do this right now? |
| "output": "http.out" | ||
| }, | ||
| { | ||
| "args": "check https://deno.land/x/fresh/src/types.ts", |
There was a problem hiding this comment.
@dsherret, I want to make actual JSR requests here. Should the spec tests allow me to do this right now?
We should make the tests work without an internet connection. Tests that rely on remote servers are often flaky and don't work when developing without an internet connection (ex. on a plane).
There was a problem hiding this comment.
We could have these codebases as git submodules, but I don't think that's desirable. I assume we'd like to keep git submodules to a minimum.
@mmastrac, I wonder if we should even do this or instead keep a mental note for the rare scenario that we change network types to do this manually.
@mmastrac and I figured it'd be worth having some sort of check for ensuring network-related types aren't broken. This is done here by simply checking that current network types don't break with Fresh, Oak and
std/http.