fix(ext/node): fix grpc error_handling example #23755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
satyarohith
force-pushed
the
grpc_error_handling
branch
from
8105fdd
to
b443ca0
Compare
bartlomieju
approved these changes
May 16, 2024
bartlomieju
added a commit
that referenced
this pull request
May 16, 2024
gRPC depends only on the END_STREAM flag to emit "trailers" event which is responsible to propagate the errors correctly. This patch uses Body::is_end_stream() to determine if a stream will end and set the END_STREAM flag. Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're emitting the 'response' event, we currently have the flags argument set to 0 instead of extracting it from the headers frame. We currently don't have a low level API to extract the flags field from HEADERS frame.
gRPC depends only on the END_STREAM flag to emit "trailers" event which is reponsible to propagate the errors correctly. This PR uses Body::is_end_stream() to determine if a stream will end and set the END_STREAM flag.
TODO:
Towards #23714