fix: widen aarch64 linux minimum GLIBC version by improving sysroot build #23791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
changed the title
mmastrac
commented
May 14, 2024
| @@ -95,51 +95,41 @@ sudo mount --rbind /home /sysroot/home | |||
| sudo mount -t proc /proc /sysroot/proc | |||
| cd | |||
|
|
|||
| if [[ \`uname -m\` == "aarch64" ]]; then | |||
There was a problem hiding this comment.
This is no longer necessary -- maybe because we're fixing up symlinks in the sysroot now?
mmastrac
changed the title
mmastrac
commented
May 14, 2024
mmastrac
commented
May 14, 2024
| @@ -700,6 +701,24 @@ const ci = { | |||
| "df -h", | |||
| ].join("\n"), | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
The binary is now smoke-tested (in sysroot and normally) after it boots to get faster feedback.
bartlomieju
reviewed
May 15, 2024
| -C link-arg=-ldl | ||
| -C link-arg=-Wl,--allow-shlib-undefined | ||
| -C link-arg=-Wl,--thinlto-cache-dir=$(pwd)/target/release/lto-cache | ||
| -C link-arg=-Wl,--thinlto-cache-policy,cache_size_bytes=700m | ||
| \${{ env.RUSTFLAGS }} | ||
| --cfg tokio_unstable |
There was a problem hiding this comment.
Do we actually need tokio_unstable? Or is it to support tokio monitor?
There was a problem hiding this comment.
This was here previously. I imagine it's just for the monitor.
bartlomieju
approved these changes
May 15, 2024
bartlomieju
pushed a commit
that referenced
this pull request
May 16, 2024
…uild (#23791) Fixes the sysroot to make it more reliable on aarch64. The sysroot we download as part of the build process now includes a small script to set up the linker flags required to build in that sysroot. Fixes #23775 Before: ``` matt@raspberrypi:~ $ ~/.deno/bin/deno /home/matt/.deno/bin/deno: /lib/aarch64-linux-gnu/libm.so.6: version `GLIBC_2.35' not found (required by /home/matt/.deno/bin/deno) ``` After: ``` matt@raspberrypi:/tmp $ ./deno Deno 1.43.3 exit using ctrl+d, ctrl+c, or close() REPL is running with all permissions allowed. To specify permissions, run `deno repl` with allow flags. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the sysroot to make it more reliable on aarch64. The sysroot we download as part of the build process now includes a small script to set up the linker flags required to build in that sysroot.
Fixes #23775
Before:
After: