Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle crashes when an external editor is launched #17717

Conversation

tsvetilian-ty
Copy link
Member

@tsvetilian-ty tsvetilian-ty commented Nov 12, 2023

Description

Recently, a permission crash was reported, so I decided to improve the experience.

  • handle general exceptions
  • add custom handling for permission exceptions

Notes: Improved error handling for external editor crashes

- handle general exceptions
- add custom handling for permission exceptions
Copy link
Member

@sergiou87 sergiou87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took us this long to get this reviewed, but it looks good! :shipit:

@sergiou87 sergiou87 merged commit 0aa5015 into desktop:development Jun 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants