Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove & forbid org.jetbrains.kotlin.js.* usage #7318

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

3flex
Copy link
Member

@3flex 3flex commented May 20, 2024

detekt does not support Kotlin/JS at this time

@3flex 3flex added this to the 2.0.0 milestone May 20, 2024
@detekt-ci
Copy link
Collaborator

Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.

Generated by 🚫 dangerJS against 1a1015f

@3flex 3flex added the housekeeping Marker for housekeeping tasks and refactorings label May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 84.75%. Comparing base (f92f8ab) to head (1a1015f).

Files Patch % Lines
...ab/arturbosch/detekt/rules/style/UnnecessaryAny.kt 0.00% 0 Missing and 2 partials ⚠️
...rbosch/detekt/rules/style/UnusedPrivateProperty.kt 33.33% 0 Missing and 2 partials ⚠️
.../arturbosch/detekt/rules/style/CanBeNonNullable.kt 0.00% 0 Missing and 1 partial ⚠️
...rbosch/detekt/rules/style/optional/OptionalUnit.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7318      +/-   ##
============================================
- Coverage     84.76%   84.75%   -0.01%     
  Complexity     3992     3992              
============================================
  Files           578      578              
  Lines         12026    12027       +1     
  Branches       2477     2479       +2     
============================================
  Hits          10194    10194              
  Misses          606      606              
- Partials       1226     1227       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3flex 3flex enabled auto-merge (squash) May 20, 2024 05:44
@3flex 3flex merged commit 83203f0 into detekt:main May 20, 2024
20 of 21 checks passed
@3flex 3flex deleted the no-js-imports branch May 20, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants