Create _dlt_* tables even when schema contract is frozen #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sultaniman
changed the title
sultaniman
commented
May 15, 2024
sultaniman
changed the title
rudolfix
requested changes
May 15, 2024
| @@ -2230,3 +2270,48 @@ def stateful_resource(): | |||
| assert len(fs_client.list_table_files("_dlt_loads")) == 2 | |||
| assert len(fs_client.list_table_files("_dlt_version")) == 1 | |||
| assert len(fs_client.list_table_files("_dlt_pipeline_state")) == 1 | |||
|
|
|||
|
|
|||
| def test_pipeline_with_frozen_schema_contract() -> None: | |||
There was a problem hiding this comment.
Please reproduce a test case that user described. All starts with a database that already has a table and a pipeline in total freeze mode! then we can look for a fix in the code
sultaniman
force-pushed
the
fix/issue-1237/create__dlt_tables
branch
from
583e8f1
to
c278878
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR let's dlt to create
_dlt_*tables even whenschema_contract=freezeResolves: #1237