Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(index): allow passing negative limits for find method #1745

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vkrishnamurthy11
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +51.89% 🎉

Comparison is base (a39c4f9) 30.06% compared to head (e56bdaf) 81.95%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1745       +/-   ##
===========================================
+ Coverage   30.06%   81.95%   +51.89%     
===========================================
  Files         133      134        +1     
  Lines        8731     8841      +110     
===========================================
+ Hits         2625     7246     +4621     
+ Misses       6106     1595     -4511     
Flag Coverage Δ
docarray 81.95% <33.33%> (+51.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/index/backends/hnswlib.py 73.99% <33.33%> (+73.99%) ⬆️

... and 109 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jupyterjazz jupyterjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vkrishnamurthy11, this looks good, I think get_current_count is a reasonable way to get the number without touching the sql table.

Can you please add tests and implement this functionality for other backends too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants