Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hirize #160

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Hirize #160

wants to merge 6 commits into from

Conversation

sefasaylan
Copy link

Hirize HR Contribute for eden.ai (hirize.hr)

Sefa SAYLAN added 3 commits March 5, 2024 16:23
Copy link
Contributor

@appelstroop appelstroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. There are some things missing. Most important, we need to make

pytest -m hirize

succeed. You have to add

from .hirize import HirizeApi

to edenai_apis/apis/__init__.py

This way, your api will be automatically tested

edenai_apis/apis/hirize/tests/test.py Outdated Show resolved Hide resolved
edenai_apis/apis/hirize/__init__.py Outdated Show resolved Hide resolved
edenai_apis/apis/hirize/hirize_api.py Outdated Show resolved Hide resolved
"file_name": file_name
})

hirize_response = requests.request("POST", self.url, headers=self.headers, data=dumpData)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be some error handling here, raising ProviderException. Problably also best to create a client.py, where the client requests are handled

import random
import requests
import json
from .client import Client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client doesnt exist

@sefasaylan sefasaylan closed this Jun 2, 2024
@sefasaylan sefasaylan reopened this Jun 2, 2024
@sefasaylan sefasaylan closed this Jun 2, 2024
@sefasaylan sefasaylan reopened this Jun 2, 2024
@sefasaylan
Copy link
Author

Hello appelstroop, after correcting my code, I sent it to you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants