Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if CsvTests required capabilities exist #108684

Merged

Conversation

ivancea
Copy link
Contributor

@ivancea ivancea commented May 15, 2024

Check that capabilities required in CSV tests really exist.

This avoids:

  • Having old capabilities (We aren't removing them afaik, so may never happen)
  • Typos in capabilities

Currently, it would probably fail in the BWC tests. But this way we avoid either waiting for them, or other potential errors.

This change was extracted from another PR where there was such typo in a commit

@ivancea ivancea added >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL v8.15.0 labels May 15, 2024
@ivancea ivancea requested a review from nik9000 May 15, 2024 15:32
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @ivancea, I've created a changelog YAML for you.

Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks @ivancea !

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
@ivancea ivancea added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label May 17, 2024
@ivancea ivancea requested a review from dnhatn May 17, 2024 14:15
@ivancea ivancea added auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) and removed auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels May 17, 2024
@elasticsearchmachine elasticsearchmachine merged commit 7b80843 into elastic:main May 17, 2024
15 checks passed
@ivancea ivancea deleted the feat/esql-capabilities-check branch May 17, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants